Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: validate webstream encoder/decoder inspector #42747

Merged
merged 1 commit into from
May 5, 2022
Merged

test: validate webstream encoder/decoder inspector #42747

merged 1 commit into from
May 5, 2022

Conversation

kuriyosh
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 15, 2022
@Trott
Copy link
Member

Trott commented Apr 15, 2022

websteam -> webstream in the commit message

@VoltrexKeyva
Copy link
Member

inpector -> inspector in commit message title, inspcetor -> inspector in commit message.

jasnell
jasnell approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nits addressed

@kuriyosh kuriyosh changed the title test: validate websteam encoder/decoder inpector test: validate webstream encoder/decoder inpector Apr 22, 2022
@kuriyosh kuriyosh changed the title test: validate webstream encoder/decoder inpector test: validate webstream encoder/decoder inspector Apr 22, 2022
@kuriyosh kuriyosh force-pushed the test-decoder-encoder-inspector branch from b635acf to b50ae1c Compare April 22, 2022 08:42
@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43701/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43715/

@github-actions github-actions bot mentioned this pull request Apr 27, 2022
Open
11 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43718/

@github-actions github-actions bot mentioned this pull request Apr 28, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43748/

This was referenced Apr 29, 2022
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43828/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. labels May 2, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42747
✔  Done loading data for nodejs/node/pull/42747
----------------------------------- PR info ------------------------------------
Title      test: validate webstream encoder/decoder inspector (#42747)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     kuriyosh:test-decoder-encoder-inspector -> nodejs:master
Labels     test, author ready, needs-ci
Commits    1
 - test: validate webstream encoder/decoder inspector
Committers 1
 - Yoshiki Kurihara 
PR-URL: https://github.com/nodejs/node/pull/42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell 
Reviewed-By: Darshan Sen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell 
Reviewed-By: Darshan Sen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: validate webstream encoder/decoder inspector
   ℹ  This PR was created on Fri, 15 Apr 2022 08:54:07 GMT
   ✔  Approvals: 5
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943586815
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943860485
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42747#pullrequestreview-943878628
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943931404
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42747#pullrequestreview-943982998
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-05-02T17:36:01Z: https://ci.nodejs.org/job/node-test-pull-request/43828/
- Querying data for job/node-test-pull-request/43828/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2259637964

@github-actions github-actions bot mentioned this pull request May 3, 2022
Open
33 tasks
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5ef83ba into nodejs:master May 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5ef83ba

RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@kuriyosh @RafaelGSS
test: validate webstream encoder/decoder inspector
d23debb 
PR-URL: #42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@kuriyosh @juanarbol
test: validate webstream encoder/decoder inspector
abafda8 
PR-URL: #42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@kuriyosh @danielleadams
test: validate webstream encoder/decoder inspector
65827cc 
PR-URL: #42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@kuriyosh @targos
test: validate webstream encoder/decoder inspector
2ba861b 
PR-URL: #42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@kuriyosh @targos
test: validate webstream encoder/decoder inspector
53cbcf0 
PR-URL: #42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@kuriyosh @guangwong
test: validate webstream encoder/decoder inspector
72a5bac 
PR-URL: nodejs/node#42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.